Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.

David Edmundson david at davidedmundson.co.uk
Thu Apr 28 16:39:34 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127780/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-integration


Description
-------

The app config (KSharedConfig::openConfig()) is a mix of the app's settings and kdeglobals.

Loading kdeglobals directly not only is a waste of resources, but breaks
one of the key features of KConfig where a user can override global settings
on a per app basis. 

What's worse is that KColorScheme when used directly does use the app config, so some apps give an inconsistent mix of results if you try and override settings.


Diffs
-----

  src/platformtheme/kfontsettingsdata.cpp 94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360 
  src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e 

Diff: https://git.reviewboard.kde.org/r/127780/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160428/fc190d86/attachment.html>


More information about the Plasma-devel mailing list