Review Request 127753: [toolbutton] Tool button disappear when move fast hover from him to task item in taskmanager

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127753/#review94951
-----------------------------------------------------------



-1


applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 271)
<https://git.reviewboard.kde.org/r/127753/#comment64460>

    Now you always enable controls whether or not the player can be controlled, see comment for visible property



applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 272)
<https://git.reviewboard.kde.org/r/127753/#comment64461>

    How does that even change something? There's a PropertyChanges in line 68 that overrides this


- Kai Uwe Broulik


On April 28, 2016, 7:13 vorm., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127753/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 7:13 vorm.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik and David Rosca.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I have no idea why 'enabled: visible' did that work
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 383c4a4 
> 
> Diff: https://git.reviewboard.kde.org/r/127753/diff/
> 
> 
> Testing
> -------
> 
> Tool button is drawed correctly
> 
> 
> File Attachments
> ----------------
> 
> Move mouse pointer fast from here to taskmanager item
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/382fc7df-83c8-4555-9952-5cc3f4c1a637__Screenshot_20160427_111049.png
> toolbutton disappear
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/4459dbb7-83f6-49f1-b412-bd3a3b514044__Screenshot_20160427_111017.png
> Screenshot_20160428_100159.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/84cf7fb4-6b18-40eb-bb8b-8c796375300f__Screenshot_20160428_100159.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160428/4b5cf98c/attachment-0001.html>