Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

Sebastian Kügler sebas at kde.org
Mon Apr 25 12:26:03 UTC 2016



> On April 25, 2016, 10:54 a.m., Anthony Fieroni wrote:
> > Ping
> 
> Sebastian Kügler wrote:
>     I think you made this hard to track, the original review request is here: https://git.reviewboard.kde.org/r/123653/
> 
> Anthony Fieroni wrote:
>     But i can't change patch, no?

I don't know, ... can you? :D (apparently not, given that I can't change this exact one...)

Anyway, I have no objections, but I understand it's different for Martin, so he needs to have another look.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127651/#review94830
-----------------------------------------------------------


On April 15, 2016, 4:05 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127651/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 4:05 a.m.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian Kügler.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt e591c81 
>   applets/minimizeall/CMakeLists.txt PRE-CREATION 
>   applets/minimizeall/Messages.sh PRE-CREATION 
>   applets/minimizeall/package/contents/config/main.xml PRE-CREATION 
>   applets/minimizeall/package/contents/ui/main.qml PRE-CREATION 
>   applets/minimizeall/package/metadata.desktop PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION 
>   applets/minimizeall/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127651/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160425/a968d8f4/attachment.html>


More information about the Plasma-devel mailing list