Review Request 127325: Replace all keywords by Qt macros

Jan Grulich jgrulich at redhat.com
Mon Apr 25 07:52:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127325/
-----------------------------------------------------------

(Updated April 25, 2016, 7:52 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Solid and Kai Uwe Broulik.


Changes
-------

Submitted with commit 936bc7e808cdcf42289ea52c5efeaef8864d9b41 by Jan Grulich to branch master.


Repository: powerdevil


Description
-------

Reason for this is new dependency on networkmanager-qt which uses some NM headers causing the error below.

Compilation error:
/usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’
   GDBusSignalInfo     **signals;


Diffs
-----

  CMakeLists.txt e7fff17 
  daemon/actions/bundled/handlebuttonevents.h 5d602d7 
  daemon/actions/bundled/handlebuttonevents.cpp 7e1d16e 
  daemon/actions/bundled/handlebuttoneventsconfig.cpp b1d4ef0 
  daemon/actions/bundled/suspendsession.h d0fc78d 
  daemon/backends/upower/backlighthelper.h b5ce7dc 
  daemon/backends/upower/backlighthelper.cpp 58b82be 
  daemon/backends/upower/powerdevilupowerbackend.h 32f0ee4 
  daemon/backends/upower/powerdevilupowerbackend.cpp 6133887 
  daemon/backends/upower/udevqtclient.cpp 52b17f6 
  daemon/kwinkscreenhelpereffect.h bc1c21b 
  daemon/kwinkscreenhelpereffect.cpp dec5d65 
  daemon/powerdevilactionconfig.cpp 2565b0d 
  daemon/powerdevilactionpool.cpp 2091879 
  daemon/powerdevilbackendinterface.cpp 7aadb01 
  daemon/powerdevilcore.cpp f02d474 
  daemon/powerdevilfdoconnector.cpp d9a3ee6 
  daemon/powerdevilpolicyagent.cpp e0d1ec6 
  daemon/powerdevilprofilegenerator.cpp cff3120 
  kcmodule/activities/activitypage.cpp ec18dee 
  kcmodule/activities/activitywidget.cpp 5992a4d 
  kcmodule/common/actioneditwidget.cpp 216399c 
  kcmodule/global/GeneralPage.h a34d54f 
  kcmodule/global/GeneralPage.cpp b2d9767 
  kcmodule/profiles/EditPage.h 4791017 
  kcmodule/profiles/EditPage.cpp 30973b2 

Diff: https://git.reviewboard.kde.org/r/127325/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160425/11d353e1/attachment.html>


More information about the Plasma-devel mailing list