Review Request 127739: [Volume applet] Show application icon
Kai Uwe Broulik
kde at privat.broulik.de
Sun Apr 24 21:51:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127739/
-----------------------------------------------------------
Review request for Plasma, KDE Usability and David Rosca.
Repository: plasma-pa
Description
-------
This adds a property "icon" to Client which manages the icon. In fact, this property was already referenced in the code but didn't exist.
Also, removes the ClientIcon.qml as the logic is now in the C++ part
Diffs
-----
applet/contents/ui/ListItemBase.qml fe4e0a1
src/client.h 3b9050e
src/client.cpp 6fc5814
src/kcm/package/contents/ui/StreamListItem.qml e40022a
src/qml/ClientIcon.qml 8256758
Diff: https://git.reviewboard.kde.org/r/127739/diff/
Testing
-------
I now get icons in the Applications tab of the applet and the ones in the KCM still work. Also fixed the icon sizing.
File Attachments
----------------
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/4feff021-2a88-48c2-b202-b5a5083616fd__Screenshot_20160424_234909.png
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160424/c8d3dcef/attachment.html>
More information about the Plasma-devel
mailing list