[Differential] [Request, 111 lines] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This limits the size of the notifications in the popup to 10 lines of text.
  The limit was removed when it was changed to a TextEdit so text could be copied from it.
  
  Unfortunately we cannot elide, so I chose to scroll the text to the bottom instead.
  This works well when multiple notifications are grouped together as there the recentmost one (ie.
  the bottom one) will be most important. For long notifications about emails it probably doesn't
  work as good but applications shouldn't dump entire novels in there anyway.
  
  BUG: 361389
  FIXED-IN: 5.7.0

TEST PLAN
  Video https://www.youtube.com/watch?v=cS7txBdLzvs&feature=youtu.be
  
  You can select text but you cannot scroll.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1479

AFFECTED FILES
  applets/notifications/package/contents/ui/Jobs.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  dataengines/notifications/notificationaction.cpp
  dataengines/notifications/notifications.operations
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h
  shell/osd.cpp
  shell/osd.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design, mck182
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160424/879528c4/attachment.html>