Review Request 127710: Some cleanup in the applet and the KCM

[Yoann Laissus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127710/
-----------------------------------------------------------

(Updated April 23, 2016, 1:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Rosca.


Changes
-------

Submitted with commit 6a96a7259a0c0a9feb69c2c30efc5dc4ca879e98 by Yoann Laissus to branch master.


Repository: plasma-pa


Description
-------

Branche "cleanup" here : git://anongit.kde.org/clones/plasma-pa/laissus/plasma-pa.git

1. Move sourceIndex and sinkIndex properties to a generic one called deviceIndex in the Stream class.

It helps us to remove the deviceType checks in the KCM (DeviceComboBox)

2. Drop sub component support for list items of the applet as it's not used anymore

As we discussed in a previous RR, it's not planned to use this component so let's clean this up !
I also unified source and sink list items into a generic one.


Diffs
-----

  CMakeLists.txt a40b99623fbbe2ba3fd874a0f73dd218fc94a42d 
  applet/contents/ui/DeviceListItemBase.qml 3376c73030470f27a11f0bbedd436fed2676fad5 
  applet/contents/ui/ListItemBase.qml d77d25a51b09149a1cf479eec0053184ae8625e6 
  applet/contents/ui/RootItem2.qml afcae47d2a9ebfa8f442e9cda93cbf53ac238ec9 
  applet/contents/ui/SinkListItem.qml 1f9c5df28405d1e5ef65deb2325d293ecb4884b1 
  applet/contents/ui/SourceListItem.qml de02c3845b4ab794c560da37c8bfe23c6eff8e46 
  applet/contents/ui/main.qml a8dbf7ded667acc6c830f70bf542b38020beaaf8 
  src/kcm/package/contents/ui/DeviceComboBox.qml e5a87e733d3009c9f4d08623f65a1c8eede303b7 
  src/kcm/package/contents/ui/SinkInputView.qml 6e165ad5349129bb10cbae39c0f8300308b44dc6 
  src/kcm/package/contents/ui/SourceOutputView.qml 3cd978b4bbf8c53e02e098e73d33ed1a169cf0c6 
  src/kcm/package/contents/ui/StreamListItem.qml b12e3f3e344fea57cc08085eb68390bac3c11749 
  src/kcm/package/contents/ui/VolumeSlider.qml 7904a5df7dcecd4abbe577d08ced131c607cbc1d 
  src/sinkinput.h a9a368cc34fcfd42079f064d90f09f52690c5fca 
  src/sinkinput.cpp cc5283b71c9af76dcc678644bd3d282bd3473f8a 
  src/sourceoutput.h 12f4a6c1d5666aea7653765b75aa099e8c1fe422 
  src/sourceoutput.cpp 66152869618426d8fb27f60d4722816ffbe5144d 
  src/stream.h 109997c1b3160bb1752d874db218d7f5a3e55f47 
  src/stream.cpp 55c0c6bf40d7b3d8ba3e97123e9f1eec4c0c9230 

Diff: https://git.reviewboard.kde.org/r/127710/diff/


Testing
-------


Thanks,

Yoann Laissus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160423/e85c1b32/attachment-0001.html>