Kirigami: pageRow refactor ready for testing

Dirk Hohndel dirk at hohndel.org
Fri Apr 22 17:13:58 UTC 2016


On Fri, Apr 22, 2016 at 06:37:38PM +0200, Marco Martin wrote:
> On Thursday 21 April 2016 11:38:25 Dirk Hohndel wrote:
> > > from my tests on the gallery app it seems at least not to have
> > > regressions (hopefully should work a bit better)
> > > if from tests looks like it works better, I'll merge it shortly.
> > 
> > Have you tried building Subsurface-mobile against it? :-)
> > 
> > That would seem like a somewhat bigger test app that you could play
> > with...
> 
> tried on the laptop so far, after a few fixes on the branch it seems to work 
> fine (not super familiar on all aspects of the app tough)
> the only thing, i would then push the little change on the header api that 
> caused problems, for which this attached patch would be needed

That looks like the change to PageRow would be completely transparent for
us... I'm a bit under water at work right now (as anyone tracking the news
might expect), so I haven't had a chance to play with this, but I will try
to find time later today...

Once you merge the branch into master let me know and I'll apply your
commit to Subsurface.

/D


More information about the Plasma-devel mailing list