Review Request 127698: Always write the theme name to plasmarc, also if the default theme is chosen

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127698/#review94757
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On April 20, 2016, 4:51 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127698/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 4:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Currently, the "name" key is deleted from plasmarc when you select the default theme (breeze) in the desktop theme KCM.
> This leads to unexpected behaviour: If you set e.g. oxygen as look&feel, and then set breeze as desktop theme, Plasma actually uses Air (the default desktop theme in the oxygen l&f) on next login instead of breeze. In other words, it is impossible to configure breeze as desktop theme when using a different look&feel as breeze.
> 
> This fixes the problem by removing the check whether the default theme is selected and always writes the "name" config key to plasmarc.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.cpp 1aaf021 
> 
> Diff: https://git.reviewboard.kde.org/r/127698/diff/
> 
> 
> Testing
> -------
> 
> Set oxygen as look&feel, then set breeze as desktop theme. On next login, breeze is indeed used as desktop theme, without the patch Plasma will fall back to Air.
> 
> Changing themes or the look&feel still works the same otherwise.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160422/8d5b19fa/attachment.html>