Review Request 127623: [digital-clock] Fix display of seconds with certain locales

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127623/#review94756
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On April 14, 2016, 1:11 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127623/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 1:11 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently, "Show Seconds" has no effect with certain locales (C e.g.) that already contain the seconds in the ShortFormat.
> The reason is that the seconds are only added to the format string that's used to display the time if they are not part of timeFormatString already (which is not used at all for the display).
> 
> This patch fixes that check and adds them only depending on the showSeconds config option.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127623/diff/
> 
> 
> Testing
> -------
> 
> Switch locale to C, seconds are shown now or not, depending on the applet's configuration, they were not shown before even when enabled.
> It still behaves as expected with my standard locale (de_AT).
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160422/ec7edb60/attachment-0001.html>