Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

David Rosca nowrep at gmail.com
Thu Apr 21 10:11:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127702/
-----------------------------------------------------------

(Updated April 21, 2016, 10:11 a.m.)


Review request for Plasma.


Changes
-------

Also fix it in get()


Repository: plasma-framework


Description (updated)
-------

ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source property will be empty for KCM pages.
This fixes correctly returning empty source for KCM pages. Also return the same value from get().


Diffs (updated)
-----

  src/plasmaquick/configmodel.cpp 3f69073 

Diff: https://git.reviewboard.kde.org/r/127702/diff/


Testing
-------

Added qml config page to plasma-pa, KCM page now works fine.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160421/f49d63cd/attachment.html>


More information about the Plasma-devel mailing list