Review Request 127696: add Positive, Neutral, Negative text colors

[Andreas Kainz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127696/#review94730
-----------------------------------------------------------



sorry marco but I'm not that good in code reading. what's the difference in the second review?

- Andreas Kainz


On April 20, 2016, 12:49 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127696/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 12:49 nachm.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> add named colors for positive (usually green)
> neutral(usually yellow) negative(usually red)
> foreground objects, such as text or parts of
> svg icons/themes
> 
> 
> Diffs
> -----
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors e242dbb 
>   autotests/themetest.cpp 3992246 
>   src/declarativeimports/core/colorscope.h b0f0ada 
>   src/declarativeimports/core/colorscope.cpp 5f7363b 
>   src/declarativeimports/core/quicktheme.h f1af4ca 
>   src/declarativeimports/core/quicktheme.cpp 3411b3d 
>   src/plasma/private/theme_p.cpp 1aaf021 
>   src/plasma/theme.h 271328c 
> 
> Diff: https://git.reviewboard.kde.org/r/127696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160420/08ccd00f/attachment.html>