[Differential] [Request, 49 lines] D1372: Fix unsetting associated application/urls for applets

kossebau (Friedrich W. H. Kossebau) noreply at phabricator.kde.org
Sun Apr 10 02:04:26 UTC 2016


kossebau created this revision.
kossebau added a reviewer: mart.
kossebau added a subscriber: plasma-devel.

REVISION SUMMARY
  Current code does not properly handle any resetting, which results
  in Applet::hasValidAssociatedApplication() still returning true
  when urls have been set to an empty list and the application name
  to an empty string.
  Also are connections to the "destroyed" signal collected on
  repeated set calls.
  This patch fixes that.
  Not happy yet with the signal/slot connection management,
  improvement proposals welcome.

BRANCH
  allowAssignedUrlAppUnsetting

REVISION DETAIL
  https://phabricator.kde.org/D1372

AFFECTED FILES
  CMakeLists.txt
  src/plasma/private/associatedapplicationmanager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, mart
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160410/e18d86b3/attachment-0001.html>


More information about the Plasma-devel mailing list