[Differential] [Request, 445 lines] D1419: Move the WindowBasedEdge into the X11 platform and create Edge through Platform

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Remove the AreaBasedEdge class
  
  No difference to Edge.
  
  Add ::window() and ::approachWindow as virtual methods to Edge
  
  This allows to no longer needing to dynamic cast the Edge to
  WindowBasedEdge for the X11 specific event handling.
  
  Create screen edge through the Platform
  
  Removes a diversion between X11 and Wayland. The base class Platform
  creates an instance of class Edge with plugin implementations being
  able to create a different type.
  
  The X11StandalonePlugin does that and creates a WindowBasedEdge. For
  this the implementation of WindowBasedEdge is moved from screenedges
  into the plugin.
  
  Unfortunately an ifdef is needed to make the screenedge test still
  work as expected. This should be improved in future, e.g. have a good
  way to load the platform plugin from the tests.

REPOSITORY
  rKWIN KWin

BRANCH
  screen-edge-platform

REVISION DETAIL
  https://phabricator.kde.org/D1419

AFFECTED FILES
  atoms.h
  autotests/CMakeLists.txt
  autotests/test_screen_edges.cpp
  platform.cpp
  platform.h
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/edge.cpp
  plugins/platforms/x11/standalone/edge.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  screenedge.cpp
  screenedge.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160415/cefa8901/attachment.html>