Review Request 123653: New Minimize Windows Plasmoid

[Martin Gräßlin]

> On April 14, 2016, 1:37 p.m., Martin Gräßlin wrote:
> > applets/minimizeall/plugin/minimizeall.h, line 49
> > <https://git.reviewboard.kde.org/r/123653/diff/2/?file=366857#file366857line49>
> >
> >     I'm not convinced that keeping the minimized windows in a list. As explained: this was a problem in KWin, that the behavior was never really defined. The patch adresses some of the problems, but the root problems is still there: What's the expected user behavior?
> >     
> >     I think that's a huge useability problem with the not well defined state. Before this goes in I want an explicit ack by the useability team.
> 
> Anthony Fieroni wrote:
>     Any suggestion? Applet *must* knows which windows to restore.

Why does the applet need to know which windows to restore? How can it even know? That's the root problem we spent years of pain with in KWin. With my experience of years as KWin maintainer, I'm not able to answer the question - for a perfect behavior we would need to be able to read the user's mind.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123653/#review94605
-----------------------------------------------------------


On Aug. 25, 2015, 12:41 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123653/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 12:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346837
>     http://bugs.kde.org/show_bug.cgi?id=346837
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> New Minimize Windows Plasmoid
> 
> This plasmoid allows to minimize windows on the current desktop. It does
> not mess with the KWindowSystem::showingDesktop flag, just allows to hide
> and show windows.
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt 7ada7ac 
>   applets/minimizeall/CMakeLists.txt PRE-CREATION 
>   applets/minimizeall/Messages.sh PRE-CREATION 
>   applets/minimizeall/package/contents/config/main.xml PRE-CREATION 
>   applets/minimizeall/package/contents/ui/main.qml PRE-CREATION 
>   applets/minimizeall/package/metadata.desktop PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION 
>   applets/minimizeall/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123653/diff/
> 
> 
> Testing
> -------
> 
> Used it for a while.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160415/385a17df/attachment-0001.html>