Review Request 127652: ScrollArea: Fix warning when contentItem is not Flickable

David Edmundson david at davidedmundson.co.uk
Fri Apr 15 00:25:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127652/#review94617
-----------------------------------------------------------


Ship it!




- David Edmundson


On April 14, 2016, 6:46 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127652/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 6:46 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml bede92c 
> 
> Diff: https://git.reviewboard.kde.org/r/127652/diff/
> 
> 
> Testing
> -------
> 
> Tested with Qt 5.6 and 5.7, in both cases keyboard navigation (up/down arrows to navigate to previous/next item) works even when interactive == false.
> So maybe we can drop the whole workaround soon?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160415/0a5445ab/attachment-0001.html>


More information about the Plasma-devel mailing list