Review Request 127586: [calendar] Add a mark to days containing events
Martin Klapetek
martin.klapetek at gmail.com
Thu Apr 14 01:16:21 UTC 2016
> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
>
> Martin Klapetek wrote:
> Working on it.
Ok so I'm unable to render that svg, it is properly installed
and everything, but this doesn't show anything (not even error):
```
PlasmaCore.Svg {
id: calendarSvg
imagePath: "widgets/calendar"
}
PlasmaCore.SvgItem {
id: eventsMarker
width: parent.width / 3
height: parent.height / 3
svg: calendarSvg
elementId: "event"
}
```
...is it missing anything? If I use say "widgets/clock" and "ClockFace", it works fine.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
-----------------------------------------------------------
On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:53 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Simple triangle at the bottom right corner, see screenshot.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/daysmodel.h 8ab232e
> src/declarativeimports/calendar/daysmodel.cpp bf99874
> src/declarativeimports/calendar/qml/DayDelegate.qml 6353827
> src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4
>
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160414/41de87ba/attachment.html>
More information about the Plasma-devel
mailing list