Review Request 127643: Right-align labels in IPv4/IPv6 dialogs
Kai Uwe Broulik
kde at privat.broulik.de
Wed Apr 13 10:34:20 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127643/#review94574
-----------------------------------------------------------
Shouldn't QFormLayout do that?
- Kai Uwe Broulik
On April 13, 2016, 10:18 vorm., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127643/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 10:18 vorm.)
>
>
> Review request for Plasma and Jan Grulich.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> The labels in the IPv4/IPv6 tabs (dialogs) are currently right-aligned. This violates the following HIG: https://techbase.kde.org/Projects/Usability/HIG/Alignment#Labels
>
> It is also not consistent with the left-aligned labels in e.g. the Wi-Fi tab.
>
> This patch right-aligns them while keeping the grid layout. An alternative could be to drop the grid layout and switch to a form layout, which automatically wuold make the labels left-aligned.
>
>
> Diffs
> -----
>
> libs/editor/settings/ui/ipv4.ui de574bd
> libs/editor/settings/ui/ipv6.ui 9f08cdc
>
> Diff: https://git.reviewboard.kde.org/r/127643/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ipv4-before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/13/62db563c-c510-4431-9b91-251fd2e50e6b__Spectacle.X19386.png
> ipv6-before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/13/82b21b6b-d69a-4acd-9553-b8e75ad234a0__Spectacle.X19393.png
> ipv4-after
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/13/b2adf599-e9f1-4c16-996c-d9f430360684__Spectacle.X19407.png
> ipv6-after
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/13/4ccfd130-99d0-491e-95cb-144cffe10ae7__Spectacle.X19416.png
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160413/90d9a611/attachment.html>
More information about the Plasma-devel
mailing list