Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

Elvis Angelaccio elvis.angelaccio at kdemail.net
Wed Apr 13 09:32:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127643/
-----------------------------------------------------------

Review request for Plasma and Jan Grulich.


Repository: plasma-nm


Description
-------

The labels in the IPv4/IPv6 tabs (dialogs) are currently right-aligned. This violates the following HIG: https://techbase.kde.org/Projects/Usability/HIG/Alignment#Labels

It is also not consistent with the left-aligned labels in e.g. the Wi-Fi tab.

This patch right-aligns them while keeping the grid layout. An alternative could be to drop the grid layout and switch to a form layout, which automatically wuold make the labels left-aligned.


Diffs
-----

  libs/editor/settings/ui/ipv4.ui de574bd 
  libs/editor/settings/ui/ipv6.ui 9f08cdc 

Diff: https://git.reviewboard.kde.org/r/127643/diff/


Testing
-------


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160413/4eb2de99/attachment.html>


More information about the Plasma-devel mailing list