Review Request 127637: bind highlightedText color in Plasma::Theme
Marco Martin
notmart at gmail.com
Wed Apr 13 08:47:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127637/
-----------------------------------------------------------
(Updated April 13, 2016, 8:47 a.m.)
Review request for Plasma.
Changes
-------
sample theme has now all different colors in complementary group, to make testing more meaningful
Repository: plasma-framework
Description
-------
we have a color in the Plasma theme "highlight" that is basically an accent color used around.. but one of the uses is to use it as a background, such as highlighted text. in that case we don't know what color would be safe for contrasting on top of it for things like the highlighted text color (plasma style used the background color for that, which is incorrect)
Diffs (updated)
-----
autotests/data/plasma/desktoptheme/testtheme/colors PRE-CREATION
autotests/data/plasma/desktoptheme/testtheme/metadata.desktop PRE-CREATION
autotests/themetest.h b6042c0
autotests/themetest.cpp 2165bef
src/declarativeimports/core/colorscope.h 38e7cc8
src/declarativeimports/core/colorscope.cpp 98ff3ab
src/declarativeimports/core/quicktheme.h 79db53c
src/declarativeimports/core/quicktheme.cpp 3ef5b88
src/declarativeimports/plasmastyle/TextAreaStyle.qml f5be27c
src/declarativeimports/plasmastyle/TextFieldStyle.qml 447d7e3
src/plasma/private/theme_p.cpp 603cf0a
src/plasma/theme.h 3f49719
Diff: https://git.reviewboard.kde.org/r/127637/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160413/55506d13/attachment.html>
More information about the Plasma-devel
mailing list