Review Request 127637: bind highlightedText color in Plasma::Theme

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127637/#review94560
-----------------------------------------------------------




autotests/themetest.cpp (lines 150 - 168)
<https://git.reviewboard.kde.org/r/127637/#comment64294>

    Why does the complementary group have the exact same colours as view? It means you're not actually testing anything
    
    See point two.



src/plasma/private/theme_p.cpp (line 505)
<https://git.reviewboard.kde.org/r/127637/#comment64293>

    This still has the same bug I pointed out in the first review. 
    
    This should be complementaryhighlightedtextcolor not view


- David Edmundson


On April 12, 2016, 3:13 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127637/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 3:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> we have a color in the Plasma theme "highlight" that is basically an accent color used around.. but one of the uses is to use it as a background, such as highlighted text. in that case we don't know what color would be safe for contrasting on top of it for things like the highlighted text color (plasma style used the background color for that, which is incorrect)
> 
> 
> Diffs
> -----
> 
>   autotests/data/plasma/desktoptheme/testtheme/colors PRE-CREATION 
>   autotests/data/plasma/desktoptheme/testtheme/metadata.desktop PRE-CREATION 
>   autotests/themetest.h b6042c0 
>   autotests/themetest.cpp 2165bef 
>   src/declarativeimports/core/colorscope.h 38e7cc8 
>   src/declarativeimports/core/colorscope.cpp 98ff3ab 
>   src/declarativeimports/core/quicktheme.h 79db53c 
>   src/declarativeimports/core/quicktheme.cpp 3ef5b88 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml f5be27c 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 447d7e3 
>   src/plasma/private/theme_p.cpp 603cf0a 
>   src/plasma/theme.h 3f49719 
> 
> Diff: https://git.reviewboard.kde.org/r/127637/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160412/00e90406/attachment.html>