[Differential] [Commented On] D1393: Refactor models

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Nice

INLINE COMMENTS
  src/maps.h:92 Not too fond of allocating a list just to get an item from it, can we perhaps do something like (m_data.constBegin() + index).value();
  src/pulseaudio.h:48 You don't need slots to connect to with the new connect syntax iirc

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1393

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: broulik, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160412/024350e2/attachment.html>