Review Request 127612: Stop removing QT_NO_CAST_FROM_ASCII

David Edmundson david at davidedmundson.co.uk
Thu Apr 7 23:38:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127612/#review94416
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On April 7, 2016, 11:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127612/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 11:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> -------
> 
> Properly construct strings and characters.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/CMakeLists.txt c4a6ce0 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 9ad1e29 
>   src/platformtheme/kdirselectdialog.cpp 0a65cd3 
>   src/platformtheme/kfontsettingsdata.cpp b0a4bbf 
>   src/platformtheme/khintssettings.cpp a70b51c 
> 
> Diff: https://git.reviewboard.kde.org/r/127612/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160407/b7ccecbf/attachment.html>


More information about the Plasma-devel mailing list