[Differential] [Request, 4 lines] D1348: Testing whether m_lastCreatedSettings is not null before calling its method

ivan (Ivan Čukić) noreply at phabricator.kde.org
Thu Apr 7 18:10:27 UTC 2016


ivan created this revision.
ivan added a reviewer: graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It looks like something was forgotten here - there is
  a completely empty body for an if statement that checks
  whether the pointer is null.
  So this might not be the desired way to fix this.
  Should m_lastCreatedSettings be instantiated instead?

REPOSITORY
  rKWIN KWin

BRANCH
  ivan/null-check-3

REVISION DETAIL
  https://phabricator.kde.org/D1348

AFFECTED FILES
  kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, graesslin
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160407/ba371bc8/attachment.html>


More information about the Plasma-devel mailing list