[Differential] [Request, 4 lines] D1345: Checking whether m_topLevel is not null before getting its property
ivan (Ivan Čukić)
noreply at phabricator.kde.org
Thu Apr 7 17:26:01 UTC 2016
ivan created this revision.
ivan added a reviewer: graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This method checks whether m_topLevel is not null in a couple
of places, but misses this one.
p.s. If there are more places where kwin does clear_or_something(); return;
it could benefit from introducing on_scope_exit and similar tricks - see
Alexandrescu's 'Declarative control flow' presentation.
REPOSITORY
rKWIN KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1345
AFFECTED FILES
shadow.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, graesslin
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160407/90e1b275/attachment.html>
More information about the Plasma-devel
mailing list