Review Request 127586: [calendar] Add a mark to days containing events

[David Edmundson]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
>     There's even exactly that on WikiBooks :D https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
>     Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can I just copy that directly and put that licence in the header and ship this in frameworks?
> 
> Martin Gräßlin wrote:
>     I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
>     I would prefer adding it to the svg theme.
>     there used to be elements for the calendar in the theme, they could get back
> 
> Martin Klapetek wrote:
>     Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
>     I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
>     Yes. Make it the highlight color of the theme (or I guess I'll be able to color it from the code right?)
> 
> Marco Martin wrote:
>     the svg would be always "highlight color" whatever is the theme. 
>     you would need other colors?
>     i'll sooner or later add some api to manipulate the stylesheet from the code, but that's not available yet
> 
> Martin Klapetek wrote:
>     I considered having different colors by event type (holiday vs calendar event), but I guess a single color will do for now.
> 
> Marco Martin wrote:
>     done.
>     widgets/calendar, loaded in a SvgItem
>     the element id is "event" that is just a triangle like in the screenshots

FYI that's in mart/plasmasvgicons not master.
(I don't know if that's intentional or not?)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
-----------------------------------------------------------


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160407/12739b29/attachment.html>