Review Request 127586: [calendar] Add a mark to days containing events
Martin Klapetek
martin.klapetek at gmail.com
Wed Apr 6 23:33:57 UTC 2016
> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they all have their own FBO.
> >
> > Can't you make the grid canvas draw the triangles, too? Or make a simple item with a triangle shaped QSGGeometryNode?
>
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can I just copy that directly and put that licence in the header and ship this in frameworks?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
-----------------------------------------------------------
On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:53 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Simple triangle at the bottom right corner, see screenshot.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/daysmodel.h 8ab232e
> src/declarativeimports/calendar/daysmodel.cpp bf99874
> src/declarativeimports/calendar/qml/DayDelegate.qml 6353827
> src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4
>
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160406/1ed40009/attachment.html>
More information about the Plasma-devel
mailing list