Review Request 127586: [calendar] Add a mark to days containing events
Martin Gräßlin
mgraesslin at kde.org
Wed Apr 6 07:10:55 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94326
-----------------------------------------------------------
a canvas element for a triangle seems a little bit too much from OpenGL point of rendering. Rendering a triangle is the basic function of OpenGL, it't the one primitive all other are build up with ;-)
- Martin Gräßlin
On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:53 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Simple triangle at the bottom right corner, see screenshot.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/daysmodel.h 8ab232e
> src/declarativeimports/calendar/daysmodel.cpp bf99874
> src/declarativeimports/calendar/qml/DayDelegate.qml 6353827
> src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4
>
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160406/6359b72a/attachment.html>
More information about the Plasma-devel
mailing list