Review Request 127260: Experiment: cache svg icons from icon theme

[Marco Martin]

> On March 31, 2016, 3:34 p.m., David Edmundson wrote:
> > src/plasma/svg.cpp, line 233
> > <https://git.reviewboard.kde.org/r/127260/diff/3/?file=454844#file454844line233>
> >
> >     Don't we need someone to call discardCache somewhere if the icon changes?
> >     (in other words, shouldn't this be in theme.cpp somewhere instead)

moved it into themeprivate, that makes the tests pass


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review94156
-----------------------------------------------------------


On April 1, 2016, 1:19 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 1:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this attempts to cache as well svg icons from the icon theme (invalidating as well when the icon theme is updated)
> 
> still to be done, to figure out to invalidate cache when the icon theme is changed in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt d475ac3 
>   src/plasma/private/theme_p.h 69a8934 
>   src/plasma/private/theme_p.cpp 98bccab 
>   src/plasma/svg.cpp 6c9c75c 
> 
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160401/a5294a55/attachment-0001.html>