Review Request 127260: Experiment: cache svg icons from icon theme

Marco Martin notmart at gmail.com
Fri Apr 1 13:19:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/
-----------------------------------------------------------

(Updated April 1, 2016, 1:19 p.m.)


Review request for Plasma.


Changes
-------

watch for the icon theme change in theme, tests on cache now work (have to duplicate the internal code in SvgPrivate to generate the id tough)


Repository: plasma-framework


Description
-------

this attempts to cache as well svg icons from the icon theme (invalidating as well when the icon theme is updated)

still to be done, to figure out to invalidate cache when the icon theme is changed in the two cases:
* theme changed with plasmashell running
* theme changed with plasma shell not running


Diffs (updated)
-----

  autotests/CMakeLists.txt d475ac3 
  src/plasma/private/theme_p.h 69a8934 
  src/plasma/private/theme_p.cpp 98bccab 
  src/plasma/svg.cpp 6c9c75c 

Diff: https://git.reviewboard.kde.org/r/127260/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160401/40464777/attachment.html>


More information about the Plasma-devel mailing list