Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review86170
-----------------------------------------------------------



shell/panelview.cpp (line 727)
<https://git.reviewboard.kde.org/r/125451/#comment59420>

    shouldn't this be "screen" as the first arg?


- David Edmundson


On Sept. 29, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 5:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp 37d0534 
>   shell/shellcorona.h 0e6fe04 
>   shell/panelview.cpp c9b1968 
>   shell/panelview.h a41f988 
>   CMakeLists.txt 4fdcf1a 
>   shell/CMakeLists.txt e17e4a3 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> -------
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150930/3ca0407b/attachment.html>