Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea

[Takahiro Hashimoto]

> On 9月 30, 2015, 9:22 a.m., David Edmundson wrote:
> > src/declarativeimports/core/tooltip.cpp, line 339
> > <https://git.reviewboard.kde.org/r/125443/diff/1/?file=408643#file408643line339>
> >
> >     I don't think you need the dismiss, It seems we can just wrap this keepAlive line in an if(m_active) 
> >     
> >     Otherwise this will have odd effect in nested ToolTipAreas even if only one is active.

Thank you for your review and comment. I agree all with you. I'd like to update my patch.

And I also agree with your additional comment below. I'd like to add patch for tooltip.qml if it's ok to include it in this change request.


- Takahiro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125443/#review86133
-----------------------------------------------------------


On 9月 29, 2015, 11:24 p.m., Takahiro Hashimoto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125443/
> -----------------------------------------------------------
> 
> (Updated 9月 29, 2015, 11:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Now PlasmaCore.ToolTipArea can control status of active/inactive.
> 
> When a ToolTip dialog is visible and making mouse move to another inactive ToolTipArea, it remains unnaturally for a while.
> 
> 
> I attached a urgy test program to reproduce this behavior. The instruction to reproduce is:
> 
> 1.run  qmlscene tooltip_hide.qml
> 2. make mouse cursor on the cell named "name1" (or any odd numbered one)
> 3. move the cursor to a even numberd cell like "name2"
> 
> It results the "tip1" tooltip remains for a long time (current spec is 4000ms)
> 
> I think it would be better when a mouse entered into an inatcive ToolTipArea, the global tooltip dialog is dismissed soon. This patch is the implementation of this behavior.
> 
> I cannot check all side-effect to change this behavior. Many guys adivce are welcomed:)
> 
> Here's my reference use case: https://git.reviewboard.kde.org/r/125402/
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.cpp 3ffcdba 
> 
> Diff: https://git.reviewboard.kde.org/r/125443/diff/
> 
> 
> Testing
> -------
> 
> Apply patch and build and test on master.
> 
> Tested with my test program attached this review request. Works fine to me.
> 
> 
> File Attachments
> ----------------
> 
> test program
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/29/c1653f27-c5b2-46e4-85bb-69a9d02720c5__tooltip_hide.qml
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150930/a649c416/attachment-0001.html>