Review Request 125445: [libtaskmanager] Protect against X11 usage on Wayland

Eike Hein hein at kde.org
Tue Sep 29 13:14:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125445/#review86109
-----------------------------------------------------------

Ship it!


Ship It!

- Eike Hein


On Sept. 29, 2015, 8:39 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125445/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 8:39 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Libtaskmanager so far only has compile time checks for windowing
> systems resulting in the X11 specific code to be executed on platform
> wayland which of course causes crashers.
> 
> This is a workaround by at least ensuring that we only call X11 specific
> code on platform X11.
> 
> 
> Diffs
> -----
> 
>   libtaskmanager/task_p.h 047ed769dfb1c8eaec58196df8a3b44533562f27 
>   libtaskmanager/task_x11.cpp 7c342c64e1604202e3747983692e3c8de20b7e77 
> 
> Diff: https://git.reviewboard.kde.org/r/125445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150929/eab9ef66/attachment.html>


More information about the Plasma-devel mailing list