Review Request 122528: [screenlocker] Grab XServer while establishing the grab

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122528/
-----------------------------------------------------------

(Updated Sept. 29, 2015, 8:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit cfef8bf23d361624bab39dde1cf4a3ccc56fcd81 by Martin Gräßlin to branch master.


Repository: plasma-workspace


Description
-------

By grabbing the XServer we can ensure that no other client is
sending X events. This eliminates a possible timing attack in
the time frame between grabbing keyboard and pointer.

At the same time the waiting and try again becomes useless as the
XServer is grabbed and no other client could release the hold
input device grab.


Diffs
-----

  ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 

Diff: https://git.reviewboard.kde.org/r/122528/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150929/47d8dd6e/attachment-0001.html>