Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item
Takahiro Hashimoto
kenya888 at gmail.com
Tue Sep 29 06:25:13 UTC 2015
> On 9月 29, 2015, 1:43 a.m., Eike Hein wrote:
> > Good idea, but can you make it so that the tooltip is only shown when the text is elided? :)
>
> Takahiro Hashimoto wrote:
> Thank you for your review and comment. Yes that's nice enhancement:) I'd like to update patch.
>
> As the contentWidth of elided text object is adjusted to the cell width I added a shadow Text element to handle original text contentWidth.
> Better alternative implementation is very welcomed. Could you have any idea? :)
And I found the issue when controling ToolTipArea active status. I proposed a patch to plasma-framework. I'm happy to see this also:)
https://git.reviewboard.kde.org/r/125443/
- Takahiro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125402/#review86055
-----------------------------------------------------------
On 9月 29, 2015, 3:01 p.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125402/
> -----------------------------------------------------------
>
> (Updated 9月 29, 2015, 3:01 p.m.)
>
>
> Review request for Plasma and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Now the label of app is elided on Kicker dashboard. It's good, of course.
>
> We sometimes want to see full text of app name, for example when the same icon is used for some apps or a app which we see first on the dashboard.
>
> PlasmaCore.ToolTipArea is good solution, I think.
>
>
> Diffs
> -----
>
> applets/kicker/package/contents/ui/ItemGridDelegate.qml 3de7aeb
>
> Diff: https://git.reviewboard.kde.org/r/125402/diff/
>
>
> Testing
> -------
>
> Build and Test on latest.
>
> 1. Open dashboard
> 2. make mouse hover on app cell.
>
> ToolTip is shown and hide on click/press enter on app cell and closing dashboard.
>
>
> File Attachments
> ----------------
>
> dash_tooltip screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/26/f02936e2-a438-4ec4-9189-10e59fd84965__kickerdash_tooltip.png
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150929/b5d3a7a7/attachment-0001.html>
More information about the Plasma-devel
mailing list