Review Request 125420: Load the mimetype file lowercase name

David Faure faure at kde.org
Mon Sep 28 21:00:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125420/#review86075
-----------------------------------------------------------

Ship it!


Please add a comment in the fallback code path, that this is for shared-mime-info < 1.3

So that we can remove that code, in 10 years ;)

- David Faure


On Sept. 28, 2015, 8:41 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125420/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 8:41 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> Since update-mime-database writes them in lowercase.
> 
> Also only complain if the names don't match in lowercase since mime names are case unsensitive.
> 
> 
> Diffs
> -----
> 
>   keditfiletype/mimetypedata.cpp ecef70d 
> 
> Diff: https://git.reviewboard.kde.org/r/125420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150928/ba3306d4/attachment.html>


More information about the Plasma-devel mailing list