Review Request 125440: Use Complementary color group for Folder View containment delegates instead of inverting Normal color group colors

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125440/#review86059
-----------------------------------------------------------

Ship it!


+2 from me if VDG is ok too

- Marco Martin


On Sept. 28, 2015, 5:33 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125440/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 5:33 p.m.)
> 
> 
> Review request for Plasma, Andrew Lake and Jens Reuterberg.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> In order to increase contrast against wallpapers, the item delegate for the Folder View desktop containment currently uses a rounded rect behind the text label. The rounded rect uses the theme's normal text color at opacity 0.4 while the text label uses the theme's background color at opacity 1.0, to essentially invert the regular colors. This was originally submitted as a patch by the VDG.
> 
> It's been brought to my attention that this isn't so great for theme authors, who don't expect the color roles to be used in an inverted fashion and feel it violates their aesthetic goals. It turns out the Plasma theming system also has a "Complementary" color group for use in similar cases, e.g. on the Logout screen. This patch makes the delegate use the Complementary color group and swaps text vs. background colors for label and background to their regular application.
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderItemDelegate.qml 8e34349 
> 
> Diff: https://git.reviewboard.kde.org/r/125440/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New delegate appearance
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/def2ec80-b4d6-4be2-8aac-a5f8e93b842f__Screenshot_20150928_193234.png
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150928/7ba4fcac/attachment.html>