Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122985/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 3:43 p.m.)


Status
------

This change has been discarded.


Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer.


Repository: kwin


Description
-------

If the window is small the list of decorations might not be visible at
all giving a bad first impression on opening systemsettings and also
making the user interface difficult to use.

This change ensures that at least two decorations are visible before
we try to show the buttons view. So only if the window is large enough
the button configuration will be shown.

Otherwise a push button is displayed to explicitly show the button config
interface. This explicit show is not bound to the size of the window.

If the window gets resized in a way that there is enough place for the
button interface the view is shown autmatically and the button is hidden.

There is no button to hide the view again. This is considered not needed
as at that point a user already has seen the view and recognized that
the list of decorations can be scrolled.


Diffs
-----

  kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d 
  kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c 

Diff: https://git.reviewboard.kde.org/r/122985/diff/


Testing
-------


File Attachments
----------------

Buttons hidden on small window
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png
Buttons automatically shown if window is large enough
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150928/1d78fb97/attachment.html>