Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112727/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 7:23 vorm.)


Status
------

This change has been discarded.


Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.


Bugs: 217560
    http://bugs.kde.org/show_bug.cgi?id=217560


Repository: kde-workspace


Description
-------

Drawback: the next trigger will go unfancied (would require listening to active window changes, no idea whether that's acceptable) but that's still much better than occluding 30 outer px of a window (see bug and http://forum.kde.org/viewtopic.php?f=111&t=112163)

Notice that
a) nor auto unhiding neither hinting happens at all while there's a(n active) fullscreen window - this is unchanged (see early exit in patched branch)
b) the patch does nothing if you don't attempt to enter the occluded area of a fullscreen window (so not even the next hinting will be affected)


Diffs
-----

  plasma/desktop/shell/panelview.cpp dcd051a 

Diff: https://git.reviewboard.kde.org/r/112727/diff/


Testing
-------

m_unhideTrigger shrinks and the next unhide is not indicated (but the panel appears), subsequent indication remains unaffected.


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150928/ba41e1ab/attachment.html>