Review Request 125420: Load the mimetype file lowercase name

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125420/#review86027
-----------------------------------------------------------



keditfiletype/mimetypedata.cpp (line 94)
<https://git.reviewboard.kde.org/r/125420/#comment59355>

    This is only true since shared-mime-info 1.3 though.
    
    So there should be a fallback lookup like I did in qtbase 4ccf5c6f4a411d367749565323f7c7fd469b025e



keditfiletype/mimetypedata.cpp (line 118)
<https://git.reviewboard.kde.org/r/125420/#comment59356>

    or faster, 
      QString::compare(mimeName, name(), Qt::CaseInsensitive) != 0


- David Faure


On Sept. 27, 2015, 2:59 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125420/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2015, 2:59 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> Since update-mime-database writes them in lowercase.
> 
> Also only complain if the names don't match in lowercase since mime names are case unsensitive.
> 
> 
> Diffs
> -----
> 
>   keditfiletype/mimetypedata.cpp ecef70d 
> 
> Diff: https://git.reviewboard.kde.org/r/125420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150928/9496b999/attachment-0001.html>