Review Request 125088: Allow to change volume with mouse wheel

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125088/#review86005
-----------------------------------------------------------


What about this, should we block the wheel events on sliders in applet as David K. suggested?

- David Rosca


On Sept. 7, 2015, 10:58 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125088/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 10:58 a.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Implement changing volume on mouse wheel.
> 
> Without this patch, the value of slider gets changed but it won't change the actual volume.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 8993b16 
>   src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 
> 
> Diff: https://git.reviewboard.kde.org/r/125088/diff/
> 
> 
> Testing
> -------
> 
> Changing volume with wheel works in both applet and kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150927/26c47820/attachment.html>