Review Request 125405: kcm_keyboard: Fix behavior of layout config edit delegates (variant, label and shortcut)

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125405/
-----------------------------------------------------------

(Updated Sept. 26, 2015, 8:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 6bb4069a9a40c7cee7ad065263fdfbca34a352bf by David Rosca to branch Plasma/5.4.


Bugs: 350757
    https://bugs.kde.org/show_bug.cgi?id=350757


Repository: plasma-desktop


Description
-------

By default, commiting edited value in QStyledItemDelegate only occurs when leaving the editor, eg. on pressing Enter or moving to other item.
This makes the delegates commit updated value to model as soon as value in editor is changed.

This also fixes the size of label editor (it now fills the entire cell) and refresh the label icons when refreshing model.


Diffs
-----

  kcms/keyboard/kcm_keyboard_widget.cpp c7a3589 
  kcms/keyboard/kcm_view_models.h 872e261 
  kcms/keyboard/kcm_view_models.cpp 093bca9 

Diff: https://git.reviewboard.kde.org/r/125405/diff/


Testing
-------

Changing the value in one of the editors now immediately enables Apply button.
Clicking Default button now correctly update label icons.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/0a6c37c7/attachment.html>