Review Request 125413: kcm_keyboard: Fix applying repeat mode settings

David Edmundson david at davidedmundson.co.uk
Sat Sep 26 18:08:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125413/#review85989
-----------------------------------------------------------

Ship it!


Given it's used in 3 places (::load ::defaults and here) can I suggest we make it a #define?

- David Edmundson


On Sept. 26, 2015, 6:04 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125413/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 6:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 349932
>     https://bugs.kde.org/show_bug.cgi?id=349932
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> set_repeat_mode was never called.
> 
> Also update default values for RepeatDelay and RepeatRate to match values from KCM defaults.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_hardware.cpp 1ab42b8 
> 
> Diff: https://git.reviewboard.kde.org/r/125413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/2ec0270d/attachment-0001.html>


More information about the Plasma-devel mailing list