Review Request 125408: kcm_keyboard: Port away from KDELibs4Support

[David Rosca]

> On Sept. 26, 2015, 4:21 p.m., David Edmundson wrote:
> > kcms/keyboard/kcm_keyboard_widget.cpp, line 130
> > <https://git.reviewboard.kde.org/r/125408/diff/1/?file=408487#file408487line130>
> >
> >     this seems important?
> >     
> >     In other cases when I've needed to do this, we just copy & paste the 2 DBus lines to emit the signal.
> >     
> >     I'm not sure what changes in kglobalsettings that other apps might possibly use though?
> 
> David Edmundson wrote:
>     edit: see my last comment, this isn't important.
>     
>     It's dropping a fairly pointless looking feature.

I think it was used only to notify KeyboardDaemon that shortcut was changed.

But as you said, it works fine without listening to globalShortcutChanged - KGlobalAccel takes care of updating the shortcut.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125408/#review85979
-----------------------------------------------------------


On Sept. 26, 2015, 2:27 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125408/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 2:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Port away from KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_daemon.cpp f2f757f 
>   kcms/keyboard/keyboard_daemon.h 4d7587f 
>   kcms/keyboard/kcm_keyboard_widget.cpp c7a3589 
>   kcms/keyboard/CMakeLists.txt abf3cf8 
>   kcms/keyboard/bindings.cpp 968721f 
> 
> Diff: https://git.reviewboard.kde.org/r/125408/diff/
> 
> 
> Testing
> -------
> 
> Builds fine, changing global shortcut still works.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/ecbb2d25/attachment.html>