Review Request 125408: kcm_keyboard: Port away from KDELibs4Support

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125408/#review85979
-----------------------------------------------------------



kcms/keyboard/kcm_keyboard_widget.cpp 
<https://git.reviewboard.kde.org/r/125408/#comment59336>

    this seems important?
    
    In other cases when I've needed to do this, we just copy & paste the 2 DBus lines to emit the signal.
    
    I'm not sure what changes in kglobalsettings that other apps might possibly use though?



kcms/keyboard/keyboard_daemon.cpp (line 134)
<https://git.reviewboard.kde.org/r/125408/#comment59339>

    FYI:
    typo in getToggeAction



kcms/keyboard/keyboard_daemon.cpp (line 180)
<https://git.reviewboard.kde.org/r/125408/#comment59338>

    This method seems redundant.
    
    before you were watching kglobalsrc config and updating our shortcuts in kglobalaccel if anyone else changes our config file.
    
    You've changed it to watch kglobalaccel for changes.
    There's not poing telling kglobalaccel if kglobalaccel changes.
    
    I think we can just kill this method.


- David Edmundson


On Sept. 26, 2015, 2:27 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125408/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 2:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Port away from KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_daemon.cpp f2f757f 
>   kcms/keyboard/keyboard_daemon.h 4d7587f 
>   kcms/keyboard/kcm_keyboard_widget.cpp c7a3589 
>   kcms/keyboard/CMakeLists.txt abf3cf8 
>   kcms/keyboard/bindings.cpp 968721f 
> 
> Diff: https://git.reviewboard.kde.org/r/125408/diff/
> 
> 
> Testing
> -------
> 
> Builds fine, changing global shortcut still works.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/687b9fac/attachment.html>