Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125369/#review85905
-----------------------------------------------------------



runners/baloo/baloosearchrunner.cpp (line 165)
<https://git.reviewboard.kde.org/r/125369/#comment59296>

    Have a look at basicindexingjob.txt. We define that all Presentation and Spreadsheets are also Documents.
    
    For text, we specifically don't do that, as then we get source code as Documents. Maybe we can make another category caleld "Source Code" or something. I'm not sure, but just combining the two doesn't seem correct.
    
    Maybe others can chime in?


- Vishesh Handa


On Sept. 24, 2015, 7:18 a.m., Igor Poboiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125369/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 7:18 a.m.)
> 
> 
> Review request for Baloo and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Small usability improvement: since presentations, spreadsheets and text files are also documents (at least, that's what I expect :) ), search for them in KRunner when "documents" category is checked.
> 
> 
> Diffs
> -----
> 
>   runners/baloo/baloosearchrunner.cpp 0023a11 
> 
> Diff: https://git.reviewboard.kde.org/r/125369/diff/
> 
> 
> Testing
> -------
> 
> It just works: now I am able to find my LaTeX-files, various presentations, etc with KRunner.
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150924/9f47fdf9/attachment.html>