Review Request 125328: kcm_keyboard: Remove Spare Layout option

[David Rosca]

> On Sept. 24, 2015, 9:03 p.m., David Edmundson wrote:
> > What doesn't work? I just tried spare layouts here, and it seemed to be behaving OK.

Oops, you are right. It works with 3 and more layouts configured.
But there is a bug when you have 2 or less configured layouts and when you open kcm the spare layouts checkbox is enabled even when it shouldn't be. I'll change this review to fix that bug instead.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125328/#review85894
-----------------------------------------------------------


On Sept. 20, 2015, 6:04 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125328/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 6:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This option is not working (it is impossible to set from KCM - clicking on enable checkbox will disable it) and also is no longer used with https://git.reviewboard.kde.org/r/125327/
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/kcm_keyboard.ui 53974e0 
>   kcms/keyboard/kcm_keyboard_widget.h 5994ea4 
>   kcms/keyboard/kcm_keyboard_widget.cpp 3ae40fc 
>   kcms/keyboard/kcm_view_models.cpp 093bca9 
>   kcms/keyboard/keyboard_config.h aff49a7 
>   kcms/keyboard/keyboard_config.cpp 1d2ee3e 
> 
> Diff: https://git.reviewboard.kde.org/r/125328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150924/6c7a45cd/attachment.html>