Review Request 125280: kded_keyboard: Don't save default config in layout memory

David Edmundson david at davidedmundson.co.uk
Thu Sep 24 20:40:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125280/#review85886
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Sept. 17, 2015, 7:53 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125280/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 7:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Don't save default layout config in layout_memory.xml to prevent growing the file too big.
> Default layout config is used as fallback, so there is no need to save it.
> 
> This affects layout_memory.xml when user set Switching Policy to Desktop or Application.
> 
> This is a followup on https://git.reviewboard.kde.org/r/125256/ because without it the saving doesn't work.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/layout_memory_persister.cpp da48739 
> 
> Diff: https://git.reviewboard.kde.org/r/125280/diff/
> 
> 
> Testing
> -------
> 
> Default layout config for app/desktop is no longer saved in layout_memory.xml
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150924/33188615/attachment.html>


More information about the Plasma-devel mailing list