Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125336/#review85835
-----------------------------------------------------------



src/plasma/private/applet_p.cpp (line 171)
<https://git.reviewboard.kde.org/r/125336/#comment59278>

    +1 to the idea, 
    
    I'm not sure this is the right place though. 
    We have an applet::setIcon that can be called at runtime from any of the applets.
    
    Arguably that should be allowed to use the "/foo" format too



src/plasma/private/packages.cpp (line 107)
<https://git.reviewboard.kde.org/r/125336/#comment59277>

    this is unrelated?


- David Edmundson


On Sept. 21, 2015, 6:11 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125336/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 6:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> restore a feature from Plasma4, the ability for plasmoids to provide
> an icon insude their package.
> intended for GHNS plasmoids,
> already used in the widget explorer, this makes it the default plasmoid icon as runtime as well.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp e2a15b61034e2896ae05893e577c143b6ed3edac 
>   src/plasma/private/packages.cpp a125f1e1616681837fad3571b8054a4b34bbbaf2 
> 
> Diff: https://git.reviewboard.kde.org/r/125336/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150923/992cbb40/attachment.html>