Review Request 125349: use a RowLayout for ToolbarLayout

[Marco Martin]

> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48
> > <https://git.reviewboard.kde.org/r/125349/diff/1/?file=405034#file405034line48>
> >
> >     So to make sure I'm clear we want to get
> >     
> >     child[0]
> >     spacer1
> >     child[1.....n-1]
> >     spacer2
> >     child[n]
> 
> Marco Martin wrote:
>     yeah
> 
> David Edmundson wrote:
>     That seems rather random. Why?
>     I predict we'll just see devs work round this by wrapping things in items or adding blank items all over the place.

...or just use RowLayout directly, that's perfectly fine
that's to look like the discussions we done at Randa on apps look.
now, i could also do this in higher level components that i'll need to do anyways and the first/last buttons would have some semantic meaning (opening/closing the left and right menu)
so it may make sense to having only centered buttons as children and properties for the left and right one.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125349/#review85751
-----------------------------------------------------------


On Sept. 22, 2015, 2:35 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125349/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 2:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> more reliable.
> also put the first and last buttons at the extremes, the others in the middle as briefly discussed with the VDG in Randa
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml 4206bed 
> 
> Diff: https://git.reviewboard.kde.org/r/125349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150923/5600732e/attachment.html>